Backport: Make user.group a nesting of the group field set (#308)#355
Merged
webmat merged 1 commit intoelastic:1.0from Mar 5, 2019
Merged
Backport: Make user.group a nesting of the group field set (#308)#355webmat merged 1 commit intoelastic:1.0from
user.group a nesting of the group field set (#308)#355webmat merged 1 commit intoelastic:1.0from
Conversation
Breaking change. Field set name "group" was being used as a leaf field at `user.group`. It had different semantics as the field set: it was a keyword field, instead of being a nesting of the field set. This goes against a driving principle of ECS, and has been corrected. We removed the `user.group` `keyword` field (introduced in elastic#204), and made the `group` field set nestable at `user.group`.
user.group a nesting of the group field set (#308)user.group a nesting of the group field set (#308)
ruflin
approved these changes
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #308 to 1.0 branch. Original message:
Breaking change.
Field set name "group" was being used as a leaf field at
user.group. It had different semantics as the field set: it was a keyword field, instead of being a nesting of the field set. This goes against a driving principle of ECS, and has been corrected.We removed the
user.groupkeywordfield (introduced in #204), and made thegroupfield set nestable atuser.group.