-
Notifications
You must be signed in to change notification settings - Fork 449
Adding new value for event.type:device
#2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2524/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
|
💚 CLA has been signed |
a1e5fff to
45f8462
Compare
MikePaquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered proposing a new value for event.type instead? It too is an array, and should accommodate the proposed "device" allowed value.
I have two concerns with adding device as a new value for event.category.
- For ECS users in general, it may cause confusion and diversion from
event.category:hostwhich is the preferred category for all host events. (FYI, when ECS was first defined, both "system" and "device" were considered before deciding on "host".) - It may be difficult to identify a device action when the
event.category(array) contains bothhostanddevice, with anevent.typevalue such asinfo. (i.e., Which is it - host info or device info?)
If instead we extend event.type to include a new allowed value of device, then an event that had:
event.kind: event
event.category:host
event.type: [device], [denied]
event.action: usb_storage_device_blocked
would be very clear that it took place on a host, and an attempt to install a device was blocked by the EDR.
@MikePaquette this makes a lot of sense @ricardo-estc do you think you can make the necessary changes based upon Mike's recommendations? |
event.category:deviceevent.type:device
|
@MikePaquette @qcorporation done, please review the updated changes |
qcorporation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MikePaquette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please close PR #2522
Please fix docs issue where "device" is not added to the list at the top

Otherwise, LGTM.
Updated docs @MikePaquette, thank you! |

1. What does this PR do?
This PR adds a new value for
event.category:deviceevent.type:device. The new value would be used to categorize events related to peripheral devices connecting to, disconnecting from, or being managed by the host operating system. This enables security teams to monitor unauthorized device usage, track hardware inventory, enforce device policies, and detect potential security threats from malicious devices or data exfiltration attempts through removable storage.Related issue: #2522