Skip to content

Conversation

@ricardo-estc
Copy link
Contributor

@ricardo-estc ricardo-estc commented Sep 4, 2025

1. What does this PR do?

This PR adds a new value for event.category:device event.type:device. The new value would be used to categorize events related to peripheral devices connecting to, disconnecting from, or being managed by the host operating system. This enables security teams to monitor unauthorized device usage, track hardware inventory, enforce device policies, and detect potential security threats from malicious devices or data exfiltration attempts through removable storage.

Related issue: #2522

@ricardo-estc ricardo-estc requested a review from a team as a code owner September 4, 2025 06:41
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2524/reference/

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🔍 Preview links for changed docs

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 4, 2025

💚 CLA has been signed

Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered proposing a new value for event.type instead? It too is an array, and should accommodate the proposed "device" allowed value.

I have two concerns with adding device as a new value for event.category.

  1. For ECS users in general, it may cause confusion and diversion from event.category:host which is the preferred category for all host events. (FYI, when ECS was first defined, both "system" and "device" were considered before deciding on "host".)
  2. It may be difficult to identify a device action when the event.category (array) contains both host and device, with an event.type value such as info. (i.e., Which is it - host info or device info?)

If instead we extend event.type to include a new allowed value of device, then an event that had:
event.kind: event
event.category:host
event.type: [device], [denied]
event.action: usb_storage_device_blocked

would be very clear that it took place on a host, and an attempt to install a device was blocked by the EDR.

@qcorporation
Copy link

Have you considered proposing a new value for event.type instead? It too is an array, and should accommodate the proposed "device" allowed value.

I have two concerns with adding device as a new value for event.category.

  1. For ECS users in general, it may cause confusion and diversion from event.category:host which is the preferred category for all host events. (FYI, when ECS was first defined, both "system" and "device" were considered before deciding on "host".)
  2. It may be difficult to identify a device action when the event.category (array) contains both host and device, with an event.type value such as info. (i.e., Which is it - host info or device info?)

If instead we extend event.type to include a new allowed value of device, then an event that had: event.kind: event event.category:host event.type: [device], [denied] event.action: usb_storage_device_blocked

would be very clear that it took place on a host, and an attempt to install a device was blocked by the EDR.

@MikePaquette this makes a lot of sense

@ricardo-estc do you think you can make the necessary changes based upon Mike's recommendations?

@ricardo-estc ricardo-estc changed the title Adding new value for event.category:device Adding new value for event.type:device Sep 4, 2025
@ricardo-estc
Copy link
Contributor Author

@MikePaquette @qcorporation done, please review the updated changes

@qcorporation qcorporation requested a review from a team September 4, 2025 15:47
Copy link

@qcorporation qcorporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close PR #2522
Please fix docs issue where "device" is not added to the list at the top
image

Otherwise, LGTM.

@ricardo-estc
Copy link
Contributor Author

ricardo-estc commented Sep 10, 2025

image

Updated docs @MikePaquette, thank you!

@mjwolf mjwolf merged commit cb73cff into main Sep 10, 2025
8 checks passed
@mjwolf mjwolf deleted the add_device_category branch September 10, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants