Skip to content

Add check for missing license headers#2378

Closed
mjwolf wants to merge 3 commits intoelastic:mainfrom
mjwolf:enforce-license-headers
Closed

Add check for missing license headers#2378
mjwolf wants to merge 3 commits intoelastic:mainfrom
mjwolf:enforce-license-headers

Conversation

@mjwolf
Copy link
Copy Markdown
Contributor

@mjwolf mjwolf commented Sep 6, 2024

Add make check_license_headers as a test workflow step, in order to detect any yaml or py files without the required license header.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? n/a

Add `make check_license_headers` as a test workflow step, in order to detect any
yaml or py files without the required license header.
@stbischof
Copy link
Copy Markdown
Contributor

https://github.com/marketplace/actions/license-eye-header

You may want to use this ci task

@stbischof
Copy link
Copy Markdown
Contributor

stbischof commented Sep 12, 2024

@mjwolf

Would be also nice if you not just check for

Licensed to Elasticsearch B.V.

But also check fot the Apache License

If its okay, i can do a pr with the ci Plugin. This way we can see this an an extra check in the pr

@mjwolf
Copy link
Copy Markdown
Contributor Author

mjwolf commented Sep 23, 2024

@mjwolf

Would be also nice if you not just check for

Licensed to Elasticsearch B.V.

But also check fot the Apache License

If its okay, i can do a pr with the ci Plugin. This way we can see this an an extra check in the pr

Hi @stbischof, if you'd like to create another PR for this, I'd appreciate it

@github-actions
Copy link
Copy Markdown
Contributor

Hi!

We just realized that we haven't looked into this PR in a while. We're
sorry!

We're labeling this PR as Stale to make it hit our filters and
make sure we get back to it as soon as possible. In the meantime, it'd
be extremely helpful if you could take a look at it as well and confirm its
relevance. A simple comment with a nice emoji will be enough :+1.

Thank you for your contribution!

@github-actions github-actions bot added the stale Stale issues and pull requests label Nov 23, 2024
@github-actions github-actions bot removed the stale Stale issues and pull requests label Dec 15, 2024
@stbischof
Copy link
Copy Markdown
Contributor

@stbischof still my task

@github-actions
Copy link
Copy Markdown
Contributor

Hi!

We just realized that we haven't looked into this PR in a while. We're
sorry!

We're labeling this PR as Stale to make it hit our filters and
make sure we get back to it as soon as possible. In the meantime, it'd
be extremely helpful if you could take a look at it as well and confirm its
relevance. A simple comment with a nice emoji will be enough :+1.

Thank you for your contribution!

@github-actions github-actions bot added the stale Stale issues and pull requests label Feb 16, 2025
@mjwolf mjwolf closed this Sep 26, 2025
@mjwolf mjwolf deleted the enforce-license-headers branch September 26, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants