Remove expected_values from *.indicator.name field defs
#2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation changes preview: https://ecs_2281.docs-preview.app.elstc.co/diff |
andrewkroh
reviewed
Sep 29, 2023
andrewkroh
approved these changes
Sep 29, 2023
chrisberkhout
approved these changes
Oct 2, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
threat.indicator.nameandthreat.enrichments.indicator.nameare misusing theexpected_valueparameter in their field definitions. This change removesexpected_value.I propose the removal is a bug fix vs. a breaking change since the current
expected_valueson these fields is not useful for real-world applications.