Remove remaining golang dependencies#1585
Merged
ebeahan merged 6 commits intoelastic:masterfrom Aug 23, 2021
Merged
Conversation
kgeller
approved these changes
Aug 20, 2021
Member
kgeller
left a comment
There was a problem hiding this comment.
Looks good! Appreciate the misspell check :)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the remaining golang dependencies in the project
Makefile.check-license-header
Remove
check-license-headerrule fromMakefilesincecheck-license-headeronly works with.gosource files.misspell
misspellbinary instead ofgo get-errorflag to throw a non-zero exit code for CIdocs/*andexperimental/schema/*directives in themisspellcheck.GitHub workflow
Remove the
setup-gostep since golang is no longer a required dependency for testing.Closes #630