add one word to threat.yml#1505
Merged
djptek merged 3 commits intoelastic:masterfrom Jul 8, 2021
djptek:threat_fields_omission
Merged
add one word to threat.yml#1505djptek merged 3 commits intoelastic:masterfrom djptek:threat_fields_omission
djptek merged 3 commits intoelastic:masterfrom
djptek:threat_fields_omission
Conversation
added 2 commits
July 8, 2021 09:58
kgeller
reviewed
Jul 8, 2021
CHANGELOG.next.md
Outdated
|
|
||
| * Swap `Location` and `Field Set` columns in `Field Reuse` table for better readability. #1472, #1476 | ||
| * Use a bullet points to list field reuses. #1473 | ||
| * Improve wording in `Threat` schema |
Member
There was a problem hiding this comment.
Don't forget to add in the PR number!
kgeller
approved these changes
Jul 8, 2021
Member
kgeller
left a comment
There was a problem hiding this comment.
LGTM after the changelog addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test? Ymakeand committed those changes? YThis is a one word addition, improves readability in docs.