Skip to content

[RFC] 0017 Deprecation of log.original Stage 3 Proposal#1465

Merged
djptek merged 9 commits intoelastic:masterfrom
djptek:rfc_0017_stage_3
Jun 23, 2021
Merged

[RFC] 0017 Deprecation of log.original Stage 3 Proposal#1465
djptek merged 9 commits intoelastic:masterfrom
djptek:rfc_0017_stage_3

Conversation

@djptek
Copy link
Copy Markdown
Contributor

@djptek djptek commented Jun 17, 2021

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Y
  • If submitting code/script changes, have you verified all tests pass locally using make test? n/a
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? n/a
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? TBC

@djptek djptek marked this pull request as draft June 17, 2021 16:38
@djptek djptek changed the title Stage 3 draft [RFC] 0017 Deprecation of log.original Stage 3 Proposal Jun 18, 2021
@djptek djptek marked this pull request as ready for review June 18, 2021 09:28
@djptek djptek requested review from a team and ebeahan and removed request for ebeahan June 18, 2021 09:28
kgeller
kgeller reviewed Jun 21, 2021
View reviewed changes
kgeller
kgeller approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebeahan
ebeahan reviewed Jun 21, 2021
View reviewed changes
@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Jun 21, 2021

A thought I had while reviewing:

We will want to update the log.original field description indicating the field's deprecation and upcoming removal from ECS.

@djptek
Copy link
Copy Markdown
Contributor Author

djptek commented Jun 22, 2021

We will want to update the log.original field description indicating the field's deprecation and upcoming removal from ECS.

This is referenced at L17 in the RFC and proposed change is here: https://github.com/djptek/ecs/blob/rfc_0017_stage_3/rfcs/text/0017/event.yml

@djptek djptek changed the title [RFC] 0017 Deprecation of log.original Stage 3 Proposal [RFC] 0017 Deprecation of log.original Stage 3 Proposal Jun 23, 2021
@djptek
Copy link
Copy Markdown
Contributor Author

djptek commented Jun 23, 2021

@elasticmachine run elasticsearch-ci/docs

@djptek djptek mentioned this pull request Jun 23, 2021
Merged
ebeahan
ebeahan approved these changes Jun 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djptek djptek merged commit 6200e56 into elastic:master Jun 23, 2021
@ebeahan ebeahan mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebeahan ebeahan ebeahan approved these changes

@kgeller kgeller kgeller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djptek @ebeahan @kgeller