[RFC] Add container metric fields - Stage 0#1441
Merged
kaiyan-sheng merged 3 commits intoelastic:masterfrom Jun 1, 2021
Merged
[RFC] Add container metric fields - Stage 0#1441kaiyan-sheng merged 3 commits intoelastic:masterfrom
kaiyan-sheng merged 3 commits intoelastic:masterfrom
Conversation
ebeahan
approved these changes
May 28, 2021
Member
ebeahan
left a comment
There was a problem hiding this comment.
LGTM for stage 0 👍
I do have a couple of observations comparing with the host.* metric fields, but we don't necessarily have to discuss in-depth in this PR.
Author
|
@ebeahan Thanks for the review! Do you have an assigned RFC number for this? |
Contributor
|
Hi @kaiyan-sheng , I just kicked off a merge master to keep you up-to-date, Please use RFC 0025 |
Member
|
I opened a follow-up PR to set the RFC's advancing date: #1447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on defining a set of fields for container inventory schema and during this process, we see some metrics that are currently not included in the container ECS fields. This RFC is to add these container metric fields into ECS so all users can leverage these fields when monitoring container performance such as CPU, memory, disk IO, and network.