[RFC] 0017 Remove log.original stage 2#1347
Merged
djptek merged 13 commits intoelastic:masterfrom May 31, 2021
djptek:rfc_0017_stage_2
Merged
[RFC] 0017 Remove log.original stage 2#1347djptek merged 13 commits intoelastic:masterfrom djptek:rfc_0017_stage_2
djptek merged 13 commits intoelastic:masterfrom
djptek:rfc_0017_stage_2
Conversation
added 2 commits
April 8, 2021 17:33
Member
|
Thanks, @djptek, for continuing to advance this. I came across a use of |
Member
|
@elastic/security-external-integrations This is a proposal to deprecate |
Contributor
Author
|
@ebeahan yep, there are a few more I would expect this could be resolved in Kibana through an alias, however that won't work in Beats and there may be further impact where I think that's less likely in Logstash, by the timelines but I'll look anyway & I will definitely need to do some digging in I will review this thoroughly update the RFC |
3 tasks
Contributor
Author
|
I ran Some of these were actually references to [Filebeat] [SIEM] Fileset for Cisco FTD logs #13286 where this change had already been implemented
The majority of references are mappings e.g. `"msg": {to:[{field: "log.original", setter: fld_set}]}`` Full list of remaining references was: |
Contributor
Author
|
Likewise Kibana has plenty of references to |
added 2 commits
May 28, 2021 15:16
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test? Ymakeand committed those changes? n/aProgress RFC 0017 Remove log.original to stage 2