[RFC] Version Type Field Migration - Stage 0#1309
Merged
ebeahan merged 6 commits intoelastic:masterfrom Apr 22, 2021
Merged
Conversation
Member
Author
|
Discussed in another channel that engaging the owners of the proposed version fields and determining which of these fields are candidates for Stage 0 acceptance is agreement that the proposed idea has merit for consideration into ECS, so I think we focus on those criteria in this PR. |
kgeller
previously approved these changes
Apr 22, 2021
Member
kgeller
left a comment
There was a problem hiding this comment.
LGTM!
I agree with your sentiment about having the broader discussion in phase 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 0 proposal for adopting the
versiontype for fields containing software version values.versionis specialized to support precedence rules based on Semantic Versioning.Stage 0 (Strawperson) Criteria:
Preview of markdown proposal