[RFC] Roll back wildcard migration to stage one#1237
Merged
ebeahan merged 3 commits intoelastic:masterfrom Jan 29, 2021
Merged
Conversation
ebeahan
commented
Jan 27, 2021
|
|
||
| <!-- An RFC should link to the PRs for each of it stage advancements. --> | ||
|
|
||
| Due to performance concerns brought up during implementation, the wildcard changes were [rolled back](https://github.com/elastic/ecs/pull/1237) to iterate on this proposal with a focus on performance implications. The original round of PRs are listed under `First Phase`, and the PRs following the rollback are grouped under `Second Phase`. |
Member
Author
There was a problem hiding this comment.
Added some additional context to this section to help someone navigate the change history.
2 tasks
f8cc599 to
82fe10d
Compare
Co-authored-by: Court Ewing <court@epixa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to performance concerns, the wildcard RFC is being rolled back to stage one.
We'll continue to iterate on the proposal with a focus on performance implications to ensure we can move forward with this important change with the schema as soon as is practical.