Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
| Scenario Outline: Deploying a <image> stand-alone agent with fleet server mode | ||
| When a "<image>" stand-alone agent is deployed with fleet server mode | ||
| Then the agent is listed in Fleet as "online" | ||
| Then the agent is listed in the Fleet UI as "online" |
There was a problem hiding this comment.
I think this will do the trick, although we'd like to read that this step belongs to the standalone agent in the spec. At least until we have a better abstraction for both existing steps (this one and the one for the managed mode) at the test suite struct level (maybe merging both structs into one instead of decoupling behaviours, at the end of the day, the end results should be the same: operate on an agent)?
Wdyt about this?
| Then the agent is listed in the Fleet UI as "online" | |
| Then the standalone agent is listed in Fleet as "online" |
| s.Step(`^the "([^"]*)" docker container is stopped$`, sats.theDockerContainerIsStopped) | ||
| s.Step(`^there is no new data in the index after agent shuts down$`, sats.thereIsNoNewDataInTheIndexAfterAgentShutsDown) | ||
| s.Step(`^the agent is listed in Fleet as "([^"]*)"$`, sats.theAgentIsListedInFleetWithStatus) | ||
| s.Step(`^the agent is listed in the Fleet UI as "([^"]*)"$`, sats.theAgentIsListedInFleetWithStatus) |
There was a problem hiding this comment.
Consequently:
| s.Step(`^the agent is listed in the Fleet UI as "([^"]*)"$`, sats.theAgentIsListedInFleetWithStatus) | |
| s.Step(`^the standalone agent is listed in Fleet as "([^"]*)"$`, sats.theAgentIsListedInFleetWithStatus) |
|
BTW, did not realise that #993 was merged, providing same implementation as I described in #994 (comment) Will close this one for that reason, but please open a follow up PR/issue for any change you consider. Thanks! |
What does this PR do?
Follow up of #978
Why is it important?
Because 978 is broken
Checklist
make noticein the proper directory)