This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: use maintenance branches instead of tags#374
Merged
mdelapenya merged 4 commits intoelastic:7.9.xfrom Oct 20, 2020
Merged
Conversation
Contributor
🐛 Flaky test report❕ There are not known flaky tests. Test stats 🧪
|
Contributor
v1v
approved these changes
Oct 19, 2020
9 tasks
cachedout
approved these changes
Oct 20, 2020
EricDavisX
reviewed
Oct 20, 2020
| - ELASTICSEARCH_HOSTS=http://elasticsearch:9200 | ||
| - ELASTIC_USERNAME=elastic | ||
| - ELASTIC_PASSWORD=changeme | ||
| image: "docker.elastic.co/observability-ci/kibana:${kibanaTag}" |
Contributor
There was a problem hiding this comment.
@mdelapenya can you discuss the differences in build times and availability of images between the observability-ci and main elastic docker images? Will this change prevent us from 'getting' a fix into the test environment faster, presuming the main docker image is built only once or twice a day, and the obs-ci is presumably built much more often?
I was also thinking in a separate issue we should dry this up and up put the version portion of the semVar in a constant.
Contributor
Author
There was a problem hiding this comment.
The observability-ci namespace is refreshed with every merge to master in beats, and for the stack they are updated automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It replaces the 7.9.2 fixed version with the 7.9-SNAPSHOT aliases.
For those places where we download a configuration file (metricbeat and elastic-agent stand-alone mode) we willl use the branch instead of the tag.
Why is it important?
It will allow us to not bump the code with every patch release, using the aliases.
Checklist
make noticein the proper directory)Author's checklist
How to test this PR locally
metricbeat
$ SUITE=metricbeat DEVELOPER_MODE=true TAGS="metricbeat" LOG_LEVEL=TRACE make -C e2e functional-testIngest Manager stand-alone
$ SUITE=ingest-manager DEVELOPER_MODE=true TAGS="stand_alone_mode" LOG_LEVEL=TRACE make -C e2e functional-testRelated issues
Follow-ups
As Beats' 7.9 branch is broken since August, we do not see validd binaries/docker images for the Elastic Agent base version, that's why it's sill kept with the 7.9.2 fixed version (see services.go)