This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore: use docker-compose provider on AMD#1736
Merged
mdelapenya merged 2 commits intoelastic:masterfrom Oct 28, 2021
Merged
Conversation
mdelapenya
commented
Oct 28, 2021
| - labels: "arm64" | ||
| - labels: "ubuntu-18.04" | ||
| provider: "elastic-package" | ||
| provider: "docker" |
Contributor
Author
There was a problem hiding this comment.
I could have simply removed the provider line for each occurrence, but I preferred to have them explicitly here for a possible rollback in the short/medium term
cachedout
approved these changes
Oct 28, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It explicitly uses the "Docker" provider at CI time, adding unit tests for the New provider method.
Why is it important?
We discovered that elastic-package tool is having some issues after merging the kibana custom configurations, causing the stack to simply not boot up:
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Follow-ups
We will eventually restore the elastic-package provider, once the issues with the tool related to maintenance branches are resolved.