Docs for lookup query vector builder in knn.md#5179
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🔍 Preview links for changed docs |
leemthompo
left a comment
There was a problem hiding this comment.
LGTM with a question and teeny nits :)
solutions/search/vector/knn.md
Outdated
| (...) | ||
| ``` | ||
|
|
||
| 1. The task to perform. In this case, it is `lookup`. |
There was a problem hiding this comment.
| 1. The task to perform. In this case, it is `lookup`. | |
| 1. Use the `lookup` query vector builder to retrieve the vector from an existing document. |
nit: this callout doesn't quite fit
solutions/search/vector/knn.md
Outdated
|
|
||
| If your query vector already exists in Elasticsearch, use the `lookup` query vector builder to fetch that vector directly from a document at search time. | ||
|
|
||
| Use `lookup` when you want query-by-example workflows, such as: |
There was a problem hiding this comment.
Would we have a link to a definition of query-by-example?
If it isn't defined satisfactorily we could just just drop "query-by-example workflows, such as" and lead straight into the bullets:
Use `lookup` when you want to:
- Find similar items for recommendations
- Retrieve related content from a seed document
- Avoid an extra client round-trip to fetch a vector before searchingAnother nit is to use parallel phrasing in lists for readability, ideally starting with action verbs 🤓
|
|
||
| ### Use `lookup` to build the query vector [knn-query-vector-lookup] | ||
| ```{applies_to} | ||
| stack: ga 9.4 |
There was a problem hiding this comment.
FYI this PR shouldn't merge until the feature is live on serverless :)
knn.md
Adding docs for the new
lookupquery vector builder. Waiting on elastic/elasticsearch#141488 to be merged.