Switch ruby client docs to asciidoctor#691
Merged
nik9000 merged 1 commit intoelastic:masterfrom Mar 8, 2019
Merged
Conversation
This switches building the ruby client docs from AsciiDoc to Asciidoctor. The html that it produces isn't 100% the same, but most the differences aren't relevant. Here is a diff of the relevant stuff: https://gist.github.com/nik9000/92e098ca9d9ce113f5d795ee1b0017ce That diff seems like a net positive.
Closed
Contributor
|
@estolfo Similar to something we've noticed while migrating the other clients, I noticed that there are no explicit anchors for the pages in the books (i.e. no [[anchor_name]] for each page). As a result, they're auto-generated, which could result in changed URLs unintentionally. If you like, I am happy to help add IDs in the source files. |
Member
Author
Contributor
|
@lcawl thanks. I'll take a look and see how I can structure the ruby client docs better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches building the ruby client docs from AsciiDoc to
Asciidoctor. The html that it produces isn't 100% the same, but most the
differences aren't relevant. Here is a diff of the relevant stuff:
https://gist.github.com/nik9000/92e098ca9d9ce113f5d795ee1b0017ce
That diff seems like a net positive.