Skip to content

Add elastic-renovate-prod[bot] to allowed_list#3035

Merged
esenmarti merged 1 commit intomasterfrom
reakaleek-patch-1
Jul 16, 2024
Merged

Add elastic-renovate-prod[bot] to allowed_list#3035
esenmarti merged 1 commit intomasterfrom
reakaleek-patch-1

Conversation

@reakaleek
Copy link
Copy Markdown
Member

@reakaleek reakaleek commented Jul 16, 2024 •
edited
Loading

This will be needed in elastic/apm-agent-python#2082 and future PRs by the bot.

@reakaleek reakaleek requested a review from a team as a code owner July 16, 2024 08:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@reakaleek reakaleek self-assigned this Jul 16, 2024
@reakaleek reakaleek requested a review from amannocci July 16, 2024 08:23
esenmarti
esenmarti reviewed Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown

@esenmarti esenmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to allowlist it in https://github.com/elastic/docs/pull/3035/files#diff-de240e145aeb06fdcdad0778d09cc3d903ebfa9f37ae29e029ab4425d7a12a5dL87? Not sure I see the difference though 😅

@esenmarti esenmarti mentioned this pull request Jul 16, 2024
Merged
@reakaleek
Copy link
Copy Markdown
Member Author

reakaleek commented Jul 16, 2024 •
edited
Loading

Do we also need to allowlist it in https://github.com/elastic/docs/pull/3035/files#diff-de240e145aeb06fdcdad0778d09cc3d903ebfa9f37ae29e029ab4425d7a12a5dL87? Not sure I see the difference though 😅

I think the the json object you are pointing to is only for a pipeline in this repo.

See https://github.com/elastic/docs/pull/3035/files#diff-de240e145aeb06fdcdad0778d09cc3d903ebfa9f37ae29e029ab4425d7a12a5dR97-R99

The other object has a repository list including elastic/apm-agent-python and other apm repos we might need.

Hence, I think we are good.

@esenmarti esenmarti enabled auto-merge (squash) July 16, 2024 13:14
@esenmarti esenmarti merged commit 612ce2d into master Jul 16, 2024
@esenmarti esenmarti deleted the reakaleek-patch-1 branch July 16, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@esenmarti esenmarti esenmarti approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@amannocci amannocci amannocci approved these changes

@leemthompo leemthompo Awaiting requested review from leemthompo leemthompo was automatically assigned from elastic/docs-repo-owners

@KOTungseth KOTungseth Awaiting requested review from KOTungseth KOTungseth was automatically assigned from elastic/docs-repo-owners

@kuisathaverat kuisathaverat Awaiting requested review from kuisathaverat

Assignees

@reakaleek reakaleek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reakaleek @xrmx @esenmarti @bmorelli25 @amannocci