Add main branch to the ecs repo docs build#2266
Merged
ebeahan merged 1 commit intoelastic:masterfrom Oct 28, 2021
Merged
Conversation
5 tasks
gtback
approved these changes
Oct 28, 2021
Member
gtback
left a comment
There was a problem hiding this comment.
LGTM!
Since the ECS book only depends on the ECS repo, this should be the only change that's needed. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
mainbranch exists in the ECS repo and is being automatically synced tomasteruntil the default branch is renamed: https://github.com/elastic/ecs/tree/mainModeled this conf change after what I've seen from other projects, but feel free to make suggestions if there's a better/different approach.