Hide X-Pack tags on versions 7.11 and later#2213
Merged
Conversation
Eventually, we'll want to remove the x-pack role from the Asciidoc for all sections/headers that include it, but until then this will at least hide the visual indicator and link. The `xpack` class will be included on the surrounding divs, since this is the default Asciidoctor behavior for "role" tags. Fixes #2207.
Member
Author
|
cc: @debadair |
nik9000
approved these changes
Sep 8, 2021
Contributor
|
Exciting! |
olksdr
approved these changes
Sep 9, 2021
Contributor
olksdr
left a comment
There was a problem hiding this comment.
looks like there are some lint issues?
otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually, we'll want to remove the x-pack role from the Asciidoc for
all sections/headers that include it, but until then this will at least
hide the visual indicator and link. The
xpackclass will be includedon the surrounding divs, since this is the default Asciidoctor behavior
for "role" tags.
Fixes #2207.