Skip to content

[WIP] Update uptime sources and build alias#1890

Merged
EamonnTP merged 1 commit intoelastic:masterfrom
EamonnTP:update-uptime-sources
Jul 8, 2020
Merged

[WIP] Update uptime sources and build alias#1890
EamonnTP merged 1 commit intoelastic:masterfrom
EamonnTP:update-uptime-sources

Conversation

@EamonnTP
Copy link
Copy Markdown

@EamonnTP EamonnTP commented Jul 8, 2020

This PR updates the source and doc build alias for the Uptime Monitoring Guide.

The Uptime monitoring content is in the process of being moved from the Kibana repo to the Observability docs repo.

@gtback
Copy link
Copy Markdown
Member

gtback commented Jul 8, 2020

I converted this to a Draft PR so it's less likely to get accidentally merged. I think we'll need to set up redirects from the old URL to the new one. Assuming the pages themselves aren't changing, a wildcard redirect should be fine.

@EamonnTP
Copy link
Copy Markdown
Author

EamonnTP commented Jul 8, 2020

Thanks @gtback

@bmorelli25
Copy link
Copy Markdown
Member

I converted this to a Draft PR so it's less likely to get accidentally merged. I think we'll need to set up redirects from the old URL to the new one. Assuming the pages themselves aren't changing, a wildcard redirect should be fine.

There shouldn't be any URL changes as a result of this PR. Only the backend content is moving

@gtback
Copy link
Copy Markdown
Member

gtback commented Jul 8, 2020

🤦 Good call @bmorelli25 . I saw the "index" attribute changed and my mind read that as a URL.

@bmorelli25
Copy link
Copy Markdown
Member

Haha, no worries. I did a double-take as well when I saw that. prefix and index are easily confused!

Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM once docs ci passes.

@EamonnTP
Copy link
Copy Markdown
Author

EamonnTP commented Jul 8, 2020

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Copy Markdown
Member

The diff looks clean to me. I think you've pulled it off!

@EamonnTP EamonnTP marked this pull request as ready for review July 8, 2020 19:34
@EamonnTP EamonnTP merged commit 6fbf45c into elastic:master Jul 8, 2020
@EamonnTP EamonnTP deleted the update-uptime-sources branch July 8, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants