Merged
Conversation
gtback
approved these changes
Jun 25, 2020
Member
gtback
left a comment
There was a problem hiding this comment.
LGTM! I'd wait for Brandon or DeDe to weigh in too, though.
dedemorton
reviewed
Jun 26, 2020
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
I'll need to take a look when you have everything in place, but looks like you're on the right track! Just one small comment.
conf.yaml
Outdated
| sections: | ||
| - title: Observability | ||
| prefix: en/observability | ||
| current: *stackcurrent |
Contributor
There was a problem hiding this comment.
Depending on when you merge this, you'll need to make sure there's a 7.8 branch if you use stackcurrent. Other option is to set this to master.
bmorelli25
requested changes
Jun 30, 2020
Member
There was a problem hiding this comment.
This PR is blocking elastic/stack-docs#1233. As discussed on Slack, @EamonnTP will update this PR to do the following:
- Update
conf.yamlto move the source of logs/metrics/observability/ingest to theobservability-docsrepo - Update
doc_build_aliases.shfor logs/metrics/observability/ingest - Update
shared/attribtues.asciidocfor logs/metrics/observability/ingest
This was referenced Jun 30, 2020
bmorelli25
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add the forthcoming Observability docs. The PR includes:
Related Issue: