Package notice file with release#32
Merged
brokensound77 merged 4 commits intoelastic:mainfrom Jul 8, 2020
Merged
Conversation
rw-access
reviewed
Jul 8, 2020
rw-access
reviewed
Jul 8, 2020
Contributor
|
@spong does this work on your end? Will Kibana's NOTICE.txt automatically update based off this? How does that work? |
Contributor
Author
|
For additional context, this will convert this repo's notice.txt to the example |
rw-access
reviewed
Jul 8, 2020
Co-authored-by: Ross Wolf <31489089+rw-access@users.noreply.github.com>
Member
Exactly! The |
spong
reviewed
Jul 8, 2020
Member
spong
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this bit of automation @brokensound77! 🙂
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
resolves #31
Summary
Converts the notice.txt file to the expected notice.ts format and stages with it rules when building a package with
build-releaseThis is the currently generated file:
Note added by @rw-access:
This will replace this file https://github.com/elastic/kibana/blob/1216b0f7cd2c0697393547432bee343ed33b96b5/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules/notice.ts