Update TLS protocol to use ECS fields#9980
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jan 14, 2019
Merged
Conversation
8ddda5b to
bca0bfd
Compare
bca0bfd to
96d4f34
Compare
adriansr
approved these changes
Jan 10, 2019
Contributor
adriansr
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvements and new tests!
Contributor
There was a problem hiding this comment.
I guess I added this to the dashboard while creating it. Can you remove it?
96d4f34 to
fbb8a1a
Compare
That dashboards were updated too. There weren't many changes needed w.r.t. fields but I did update the visualizations and saved searches to include `[Packetbeat]` in their names. I added a python test case for TLS and discovered a few fields that were not documented so I updated the fields docs accordingly. Here's a summary of what fields changed. Part of elastic#7968 Changed - responsetime -> event.duration (unit are now nanoseconds) Added - event.dataset = tls - event.end - event.start - network.community_id - network.protocol = tls - network.type - source.domain (added if there's a SNI value) Unchanged Packetbeat Fields - status - type = http (we might remove this since we have event.dataset)
fbb8a1a to
e0c1a4f
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is based on another open PR so please only review the last commit
That dashboards were updated too. There weren't many changes needed w.r.t. fields
but I did update the visualizations and saved searches to include
[Packetbeat]in theirnames.
I added a python test case for TLS and discovered a few fields that were not documented
so I updated the fields docs accordingly.
Here's a summary of what fields changed.
Part of #7968
Changed
Added
Unchanged Packetbeat Fields