Update event.dataset to contain module and fileset name#9922
Merged
ruflin merged 2 commits intoelastic:masterfrom Jan 8, 2019
Merged
Update event.dataset to contain module and fileset name#9922ruflin merged 2 commits intoelastic:masterfrom
ruflin merged 2 commits intoelastic:masterfrom
Conversation
`event.dataset` contains `module + fileset` name to be unique. We made this change in 6.6 / 6.x but it seems it slipped through in master where it contained still the old data. `fileset.name` is reintroduced with the old name for compatibility reasons but also to have the a field around which is the same as what users configured in a module under `fileset`.
urso
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.datasetcontainsmodule + filesetname to be unique. We made this change in 6.6 / 6.x but it seems it slipped through in master where it contained still the old data.fileset.nameis reintroduced with the old name for compatibility reasons but also to have the a field around which is the same as what users configured in a module underfileset.