Metricbeat redis refactors#9907
Merged
jsoriano merged 11 commits intoelastic:masterfrom Jan 14, 2019
Merged
Conversation
houndci-bot
reviewed
Jan 5, 2019
ruflin
approved these changes
Jan 7, 2019
sayden
suggested changes
Jan 8, 2019
Contributor
sayden
left a comment
There was a problem hiding this comment.
Some comments to improve debugging and error handling.
Member
Author
|
Thanks for the reviews! I have added more context information to errors, this would be ready for another review. |
kaiyan-sheng
approved these changes
Jan 8, 2019
ruflin
approved these changes
Jan 9, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Great to see one more metricset based on the reporter.
ruflin
approved these changes
Jan 11, 2019
Contributor
ruflin
left a comment
There was a problem hiding this comment.
I'm good with merging as is. We should discuss the Event return code handling in a follow up issue / internal discussion and not block this PR on it.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 14, 2019
Refactor redis metricsets to reuse common code, ensure that connection pools are closed when metricset is stopped and to use v2 reporters. Move password tests from info metricset to module level. Add test for info fetching. (cherry picked from commit cacf231)
jsoriano
added a commit
that referenced
this pull request
Jan 17, 2019
Refactor redis metricsets to reuse common code, ensure that connection pools are closed when metricset is stopped and to use v2 reporters. Move password tests from info metricset to module level. Add test for info fetching. (cherry picked from commit cacf231)
This was referenced Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor redis metricsets to reuse common code, ensure that connection pools are closed when metricset is stopped and to use v2 reporters.
Move password tests from info metricset to module level.
Add test for info fetching.
Fixes #9678