[Auditbeat] Cherry-pick #9863 to 6.x: Process metricset: Skip permission errors on Windows#9886
Merged
cwurm merged 1 commit intoelastic:6.xfrom Jan 4, 2019
Merged
Conversation
…stic#9863) Changes the process metricset to skip the System Process (PID: 0) as well as any process access has been denied to on Windows. Adds Windows to the documentation. Fixes elastic#9748. (cherry picked from commit 72b96a7)
Contributor
|
Pinging @elastic/secops |
webmat
approved these changes
Jan 4, 2019
Contributor
webmat
left a comment
There was a problem hiding this comment.
LGTM
CI failures both appear to be Docker flakyness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9863 to 6.x branch. Original message:
The
processmetricset tests were failing on Windows because they were trying to open processes that cannot be opened (the System and Idle Processes, and any CSRSS process - see OpenProcess).This change skips the System Process (PID: 0) as well as any process access has been denied to.
Since the
processmetricset seems to be working well on Windows now, this also adds Windows to the documentation (Note: The system module remains marked asexperimentalfor now).Fixes #9748.