Cherry-pick #9617 to 6.x: Fix issue with ILM that write index was created before template was loaded#9628
Merged
ruflin merged 1 commit intoelastic:6.xfrom Dec 18, 2018
Merged
Conversation
…oaded (elastic#9617) The write index for ILM was created before the template was loaded. This meant the first template did not contain all the mappings and policy for ILM so was never rolled over. This change makes sure the template is loaded for ILM is setup up and adds a test to confirm it. Further ILM was not respected when running `metricbeat setup --template`. This is now changed too. (cherry picked from commit 36cee51)
ph
approved these changes
Dec 18, 2018
Contributor
ph
left a comment
There was a problem hiding this comment.
LGTM i've rekicked the tests on travis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9617 to 6.x branch. Original message:
The write index for ILM was created before the template was loaded. This meant the first template did not contain all the mappings and policy for ILM so was never rolled over. This change makes sure the template is loaded for ILM is setup up and adds a test to confirm it.
Further ILM was not respected when running
metricbeat setup --template. This is now changed too.mockbeat was modified to send multiple events instead of just one to allow the new tests.