Update migration file to new structure#9381
Conversation
|
Pinging @elastic/infrastructure |
160bda9 to
388e342
Compare
dev-tools/ecs-migration.yml
Outdated
There was a problem hiding this comment.
I don't see that fix. Have you pushed? 😂
webmat
left a comment
There was a problem hiding this comment.
LGTM. Just a nit about adding a comment for the meaning when alias6 is absent
|
Yeah I did read through quickly. Will pore through it one more time. |
The new structure makes it clear which alias have to happen in 6.x and which ones in 7.x
388e342 to
782a491
Compare
| copy_to: false | ||
|
|
||
| - from: beat.hostname | ||
| to: agent.hostname |
There was a problem hiding this comment.
@MikePaquette is pushing back on agent.hostname, btw.
Agent should always be running on the host itself. If the monitoring agent is outside of the host, it should be represented in observer.hostname (used to be called device.hostname, but device is being renamed to observer).
There was a problem hiding this comment.
Should be addressed in another PR, though.
webmat
left a comment
There was a problem hiding this comment.
I went through the file again. The mappings look good, but I think the Auditbeat mapping should be removed.
There should be a pull request to address Auditbeat in its entirety.
The new structure makes it clear which alias have to happen in 6.x and which ones in 7.x