Skip to content

Skip flaky tests seen in #9194#9217

Merged
jsoriano merged 2 commits intoelastic:masterfrom
jsoriano:flaky-tests-9194
Nov 23, 2018
Merged

Skip flaky tests seen in #9194#9217
jsoriano merged 2 commits intoelastic:masterfrom
jsoriano:flaky-tests-9194

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Nov 23, 2018

Skip flaky tests seen in #9194 (#9213, #9214, #9215, #9216)

@jsoriano jsoriano added review Filebeat Filebeat libbeat flaky-test Unstable or unreliable test cases. labels Nov 23, 2018
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Nov 23, 2018

Umm, same tests failed 🤦‍♂️ maybe they are not so flaky, and I should have used os.name == 'nt', I'll try again.

@ph
Copy link
Copy Markdown
Contributor

ph commented Nov 23, 2018

@jsoriano Not they that aren't flaky, I think it's from the go 1.11.2 upgrade.

@ph ph mentioned this pull request Nov 23, 2018
8 tasks
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Nov 23, 2018

@ph I think some of them were flaky before, just not that constant.

@ph
Copy link
Copy Markdown
Contributor

ph commented Nov 23, 2018

I think some of them were flaky before, just not that constant.

Correct, but I would say its more a permanent state now.

@jsoriano jsoriano merged commit a07884e into elastic:master Nov 23, 2018
@jsoriano jsoriano deleted the flaky-tests-9194 branch November 23, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filebeat Filebeat flaky-test Unstable or unreliable test cases. libbeat review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants