Cherry-pick #8316 to 6.x: Add required comments to heartbeat monitors#8362
Merged
andrewvc merged 1 commit intoelastic:6.xfrom Sep 27, 2018
Merged
Cherry-pick #8316 to 6.x: Add required comments to heartbeat monitors#8362andrewvc merged 1 commit intoelastic:6.xfrom
andrewvc merged 1 commit intoelastic:6.xfrom
Conversation
Some of these functions needed comments to keep inline with go style guides. I also simplified one error by using errors.New instead of a custom error struct. (cherry picked from commit 28977fb)
jsoriano
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8316 to 6.x branch. Original message:
Some of these functions needed comments to keep inline with go style guides. The change that introduced these was in #8023 .
I also simplified one error by using errors.New instead of a custom error struct.