Cherry-pick #8140 to 6.x: Force input to file in filebeat module tests#8163
Merged
jsoriano merged 1 commit intoelastic:6.xfrom Aug 30, 2018
Merged
Cherry-pick #8140 to 6.x: Force input to file in filebeat module tests#8163jsoriano merged 1 commit intoelastic:6.xfrom
jsoriano merged 1 commit intoelastic:6.xfrom
Conversation
There can be modules that support multiple inputs, currently we only support module tests with file input so modules whose default input is a different one fails. This change assumes that a `var.input` setting is used to select the input, and sets it to file on tests. (cherry picked from commit 30ac8e8)
kvch
approved these changes
Aug 30, 2018
Member
Author
|
Failing tests are not related, merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8140 to 6.x branch. Original message:
There can be modules that support multiple inputs, currently we only
support module tests with file input so modules whose default input is a
different one fails. This change assumes that a
var.inputsetting isused to select the input, and sets it to file on tests.