Cherry-pick #8091 to 6.x: Publisher pipeline: pass logger and metrics registry#8147
Merged
urso merged 1 commit intoelastic:6.xfrom Oct 22, 2018
Merged
Cherry-pick #8091 to 6.x: Publisher pipeline: pass logger and metrics registry#8147urso merged 1 commit intoelastic:6.xfrom
urso merged 1 commit intoelastic:6.xfrom
Conversation
8fa8415 to
62b8734
Compare
ruflin
approved these changes
Aug 30, 2018
Author
|
Jenkins test this please. |
ph
approved these changes
Sep 24, 2018
We should strive to not have dependencies on globals in beats. The publisher pipeline rewrite made sure we don't work with globals internally. Yet some globals have been introduced since, and even though the library didn't use globals internally, initialization still did use globals at some points. This change removes globals for logging/metrics/telemetry, by requiring the beat instance to pass down required instances. (cherry picked from commit 8c15e6e)
62b8734 to
08d970a
Compare
Contributor
|
Let's get this one in first, as I guess #8657 will conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8091 to 6.x branch. Original message:
We should strive to not have dependencies on globals in beats. The
publisher pipeline rewrite made sure we don't work with globals
internally. Yet some globals have been introduced since, and even though
the library didn't use globals internally, initialization still did use
globals at some points.
This change removes globals for logging/metrics/telemetry, by requiring
the beat instance to pass down required instances.