Skip to content

Add GetLicense to Elasticsearch client#7953

Closed
ruflin wants to merge 1 commit intoelastic:masterfrom
ruflin:es-license-check
Closed

Add GetLicense to Elasticsearch client#7953
ruflin wants to merge 1 commit intoelastic:masterfrom
ruflin:es-license-check

Conversation

@ruflin
Copy link
Copy Markdown
Contributor

@ruflin ruflin commented Aug 13, 2018

This allows feature like ILM to check the License of the Elasticsearch cluster to see if the feature will work or not.

Open questions:

  • Should we check for expiration?
  • I only tested with trial and basic, is the license type for gold and platinum correct?
  • Is trial always platinum license?
  • What does the API endpoint look like if the trial is expired?

This allows feature like ILM to check the License of the Elasticsearch cluster to see if the feature will work or not.
@ruflin ruflin added in progress Pull request is currently in progress. discuss Issue needs further discussion. review :Outputs libbeat labels Aug 13, 2018
return conn.version
}

func (conn *Connection) GetLicense() (int, error) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method Connection.GetLicense should have comment or be unexported

)

const (
LicenseApache = iota
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported const LicenseApache should have comment (or a comment on this block) or be unexported

@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Aug 13, 2018

Closing in favor of #7946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss Issue needs further discussion. in progress Pull request is currently in progress. libbeat :Outputs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants