Make URLHostParserBuilder support a basepath setting#7700
Merged
andrewkroh merged 1 commit intoelastic:masterfrom Jul 24, 2018
ycombinator:metricbeat/host-parser/support-basepaths
Merged
Make URLHostParserBuilder support a basepath setting#7700andrewkroh merged 1 commit intoelastic:masterfrom ycombinator:metricbeat/host-parser/support-basepaths
andrewkroh merged 1 commit intoelastic:masterfrom
ycombinator:metricbeat/host-parser/support-basepaths
Conversation
andrewkroh
approved these changes
Jul 24, 2018
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. I would mention the basepath setting in the changelog under Added/Metricbeat.
Also can you check to see if there is documentation for the http based metricsets where we can add basepath.
Contributor
Author
|
Done and done @andrewkroh. Also squashed commits into single one. |
Member
|
@ycombinator I'm thinking that |
Contributor
Author
|
Aha, didn't know about that doc. Thanks @andrewkroh! Added. |
This will allow modules using URLHostParserBuilder to support a setting named "basepath" in their configuration. If users set this setting to some value, the value will be inserted into the HTTP URI as the first path segment.
ruflin
approved these changes
Jul 24, 2018
andrewkroh
approved these changes
Jul 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow modules using URLHostParserBuilder to support a setting named "basepath" in their configuration. If users set this setting to some value, the value will be inserted into the HTTP URI as the first path segment.
Replaces #7682.