Nested fields for all types in common.Schema#7583
Merged
ruflin merged 1 commit intoelastic:masterfrom Jul 13, 2018
Merged
Conversation
2619e42 to
436e6c2
Compare
436e6c2 to
b469b6c
Compare
ycombinator
approved these changes
Jul 12, 2018
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
Personally, I'm +1 to this change, for consistency and convenience reasons. Thanks for adding the tests as well. LGTM!
Member
Author
|
@ruflin wdyt? |
Contributor
|
+1 on this change. Tried to think of some edge cases that it could break but couldn't come up with any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to get nested fields from other types in
mapstrifacein common.Schema. It was already allowed onstringandinterface{}, added a test also to check the behaviour.Not sure however if this is the intended behaviour.