Conversation
libbeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
exported function Generate should have comment or be unexported
libbeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
exported type YmlFile should have comment or be unexported
libbeat/cmd/instance/beat.go
Outdated
There was a problem hiding this comment.
comment on exported method Beat.GenerateGlobalFields should be of the form "GenerateGlobalFields ..."
libbeat/cmd/generate.go
Outdated
There was a problem hiding this comment.
exported var BeatsPath should have comment or be unexported
filebeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
filebeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
filebeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
filebeat/generator/fields/fields.go
Outdated
There was a problem hiding this comment.
exported function Generate should have comment or be unexported
filebeat/cmd/generate.go
Outdated
There was a problem hiding this comment.
error strings should not be capitalized or end with punctuation or a newline
16b848e to
74dd3ea
Compare
619b9e8 to
789170a
Compare
|
I rebased the PR. But it still has a few minor problems, before it becomes ready to review. |
|
Closing in favour of #9314 |
A new subcommand is added named
generateto all Beats. This command has a few more subcommands in case of Filebeat.Motivation
This is the next baby step to removing Python from
make updateand making it possible for all users without development envs to generate files, if they edited something locally (including generating FB module).Subcommands in case of all Beats (e.g. Metricbeat):
Subcommands of
generate:global-fields: The existingfields.ymlcollector is ported to Golang and is unified for all Beats. The behaviour is not changed. The collectedfields.ymlfiles are concatenated into one globalfields.ymland placed under_meta.kibana-index-pattern: The existing Golang script is exposed as a subcommand.Subcommands of Filebeat:
Special subcommands of Filebeat:
fields: Existing script is exposed.fileset: Existing script is exposed.module: Existing script is exposed.Misc additions
filebeat/generatorfromfilebeat/scripts/generatorkeystoreTODO
Depends on: #6911