Skip to content

Wrong assertions and types conversion on the logstash slow plain format.#6318

Merged
exekias merged 2 commits intoelastic:masterfrom
ph:fix/assertion-fails-master-logstash
Feb 8, 2018
Merged

Wrong assertions and types conversion on the logstash slow plain format.#6318
exekias merged 2 commits intoelastic:masterfrom
ph:fix/assertion-fails-master-logstash

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Feb 7, 2018

We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: #6317

@ph
Wrong assertions and types conversion on the logstash slow plain format.
b7aeec3 
We were doing an autoconvert vs a long convert and somehow it change the
logic and the assertions.

Fixes: #6317
@ph ph added Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. labels Feb 7, 2018
@ph ph added the review label Feb 7, 2018
@ph
Copy link
Copy Markdown
Contributor Author

ph commented Feb 8, 2018

jenkins test this please

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Feb 8, 2018

The build passed on travis, but was interrupted on Jenkins.

ubuntu
02:47:44 Aborted
02:47:44 Aborted by unknown
02:47:44 Interrupting #3132
02:47:44 Finished: ABORTED

This was referenced Feb 8, 2018
Merged
Merged
Merged
@exekias exekias merged commit 6fe02a4 into elastic:master Feb 8, 2018
This was referenced Feb 13, 2018
Merged
Closed
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Filebeat Filebeat review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ph @exekias