revert event.type and use input.type instead#6227
Merged
ruflin merged 1 commit intoelastic:masterfrom Jan 31, 2018
ph:fix/revert-event-type
Merged
revert event.type and use input.type instead#6227ruflin merged 1 commit intoelastic:masterfrom ph:fix/revert-event-type
event.type and use input.type instead#6227ruflin merged 1 commit intoelastic:masterfrom
ph:fix/revert-event-type
Conversation
This commit revert the decision done in #6078 and will use `input.type` to replace the `prospector.type`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit revert the decision done in #6078 and will use
input.typeto replace theprospector.typeAfter discussing with @ruflin we have agreed that this change was done too soon before the ECS format was stable and we have decided to use
input.typeinstead, so we don't block theevent.typekey when ECS finally land.