Migrate: modules yaml and their json expected file to use the input and the input.type field#6121
Merged
ruflin merged 1 commit intoelastic:masterfrom Feb 3, 2018
ph:refactor/rename-modules-to-use-input
Merged
Migrate: modules yaml and their json expected file to use the input and the input.type field#6121ruflin merged 1 commit intoelastic:masterfrom ph:refactor/rename-modules-to-use-input
ruflin merged 1 commit intoelastic:masterfrom
ph:refactor/rename-modules-to-use-input
Conversation
10 tasks
d027f45 to
0e31dc7
Compare
Contributor
|
@ph I know I brought up this change but I have second thoughts now :-( Can we sync up next week? |
Contributor
Author
|
Of course, do you expect compatibility issue?
On Sat, Jan 27, 2018 at 5:44 PM Nicolas Ruflin ***@***.***> wrote:
@ph <https://github.com/ph> I know I brought up this change but I have
second thoughts now :-( Can we sync up next week?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6121 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgD01VBxCrwcGAL2KTF1MB3lm8fk3ks5tO6a-gaJpZM4RlEr3>
.
--
ph
|
Contributor
|
No, more if it's the correct field :-( |
Contributor
Author
|
Np lets bring it up in the sync
On Sat, Jan 27, 2018 at 5:53 PM Nicolas Ruflin ***@***.***> wrote:
No, more if it's the correct field :-(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6121 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgDx4vSHFsjRzvaN0qRkL3ErG8Ev3ks5tO6jxgaJpZM4RlEr3>
.
--
ph
|
Contributor
Author
|
jenkins test this please |
instead of prospector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate: modules yaml and their json expected file to use the input and
input.typefieldrequire: #6078