Skip to content

Migrate: Log prospector to the input interface#6120

Merged
ruflin merged 1 commit intoelastic:masterfrom
ph:refactor/log-prospector-to-input
Feb 3, 2018
Merged

Migrate: Log prospector to the input interface#6120
ruflin merged 1 commit intoelastic:masterfrom
ph:refactor/log-prospector-to-input

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Jan 19, 2018

require #6078

@ph ph added in progress Pull request is currently in progress. Filebeat Filebeat labels Jan 19, 2018
@ph ph changed the title Migrate: Log prospect to the input interace and rename prospector to Migrate: Log prospector to the input interface Jan 19, 2018
@ph ph mentioned this pull request Jan 19, 2018
10 tasks
@ph ph force-pushed the refactor/type-aliasing-input branch from d027f45 to 0e31dc7 Compare January 22, 2018 18:35
@ph ph changed the base branch from refactor/type-aliasing-input to master January 23, 2018 02:46
@ph ph added review and removed in progress Pull request is currently in progress. labels Jan 23, 2018
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ph LGTM. Left one minor question.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you prefix it here with input? It should already be input.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check that, i believe my editor did this change.

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Jan 30, 2018

@ruflin rebase and removed the input, not sure about the import, I've never managed the import manually.

@ruflin ruflin merged commit 14f0927 into elastic:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants