Migrate: UDP prospector the input interface#6118
Merged
ruflin merged 2 commits intoelastic:masterfrom Feb 1, 2018
ph:refactor/udp-prospector-to-input
Merged
Migrate: UDP prospector the input interface#6118ruflin merged 2 commits intoelastic:masterfrom ph:refactor/udp-prospector-to-input
ruflin merged 2 commits intoelastic:masterfrom
ph:refactor/udp-prospector-to-input
Conversation
10 tasks
d027f45 to
0e31dc7
Compare
ruflin
reviewed
Jan 25, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Left one minor question.
filebeat/prospector/prospector.go
Outdated
Contributor
There was a problem hiding this comment.
How is this related to this change?
Contributor
Author
|
@ruflin update/rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the input prospector to use the input interface
Require: #6078