Migrate: STDIN prospector to the input interface#6116
Migrate: STDIN prospector to the input interface#6116ruflin merged 1 commit intoelastic:masterfrom ph:refactor/stdin-prospector-to-input
Conversation
d027f45 to
0e31dc7
Compare
filebeat/input/stdin/input.go
Outdated
There was a problem hiding this comment.
is Input used in any other place? Let's not export symbols not required by other modules.
E.g. plugin types in libbeat outputs are not exported.
There was a problem hiding this comment.
I don't think its used outside like I've said when I have renamed the Prospector/input, I didn't revise any visibility I can certainly do a check on it, since all those PRs are small.
There was a problem hiding this comment.
Let's do this in a second step as it will cause name conflicts in this PR.
I'm tempted to say there will be Inputs which use some part of an other Input.
There was a problem hiding this comment.
After giving some thinking I agree with @ruflin
|
@ph Can you rebase because of the CHANGELOG conflict? |
|
@ruflin rebased. |
|
@ph Sorry, needs rebase. I wonder if we should have a changelog entry for each migration or just one entry that links to the meta issue? |
|
Or do the change log in another pr
On Thu, Feb 1, 2018 at 3:46 AM Nicolas Ruflin ***@***.***> wrote:
@ph <https://github.com/ph> Sorry, needs rebase. I wonder if we should
have a changelog entry for each migration or just one entry that links to
the meta issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6116 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgF5AaT79oCEJXQWf17r22HXEW_YUks5tQXnSgaJpZM4Rk8H0>
.
--
ph
|
Use the input interface instead of the prospector.
Require: #6078