Skip to content

Update go-structform#5810

Merged
ruflin merged 1 commit intoelastic:masterfrom
urso:upd/go-structform-0.0.2
Dec 6, 2017
Merged

Update go-structform#5810
ruflin merged 1 commit intoelastic:masterfrom
urso:upd/go-structform-0.0.2

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Dec 5, 2017

Update to v0.0.2

Added

  • Add struct tag option ",omitempty".
  • Add StringConvVisitor converting all primitive values to strings.
  • Move and export object visitor into visitors package

Fixed

  • Fix invalid pointer indirections in struct to array/map.

@ph
Copy link
Copy Markdown
Contributor

ph commented Dec 5, 2017

@urso the make check fails because we miss the update to the NOTICE.txt

@urso urso force-pushed the upd/go-structform-0.0.2 branch from 18cf380 to a5ae477 Compare December 5, 2017 23:32
@urso
Copy link
Copy Markdown
Author

urso commented Dec 5, 2017

@ph thanks. Always forget make notice :/

@ruflin ruflin merged commit 3499bf7 into elastic:master Dec 6, 2017
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Dec 6, 2017

I wonder if the fixed part had any affect on existing beats, meaning is it worth to note it in the changelog?

@urso
Copy link
Copy Markdown
Author

urso commented Dec 6, 2017

It's some error I found while unit testing, but as beats uses go-structform with common.MapStr after normalization beats are not affected.

@ph
Copy link
Copy Markdown
Contributor

ph commented Dec 6, 2017 via email

@urso urso deleted the upd/go-structform-0.0.2 branch February 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants