Skip to content

[Docs] Add module config reload docs#4930

Merged
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:modules_reload
Aug 18, 2017
Merged

[Docs] Add module config reload docs#4930
dedemorton merged 1 commit intoelastic:masterfrom
dedemorton:modules_reload

Conversation

@dedemorton
Copy link
Copy Markdown
Contributor

No description provided.

reload.period: 10s
------------------------------------------------------------------------------

TIP: If you are using the <<modules-command,`modules`>> command to enable and
Copy link
Copy Markdown
Contributor Author

@dedemorton dedemorton Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exekias I'm not sure if I'm going far enough here. I think it might be better to show the modules.d path in the config example here rather than just mentioning it as an aside. WDYT? (still need to write those docs...tomorrow)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so, we show a common path from doc, while it's clear you can change it if you want

@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Aug 17, 2017
Each file found by the Glob must contain a list of one or more module
definitions. For example:

//REVIEWERS: I got an error when I tried to have an empty line before the -module: mysql entry below. Shouldn't whitespace be allowed there?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm I think it should be allowed so we may file a bug for this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. I was not able to reproduce this issue. Maybe I had a tab or something on that line? Anyhow...if I can't reproduce the problem, it doesn't exist, right? :-)

Copy link
Copy Markdown
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 to change example path to modules.d

@dedemorton dedemorton merged commit 5b09248 into elastic:master Aug 18, 2017
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants