[9.3](backport #48054) [Metricbeat] Add memory PSI metrics for cgroupv2#49057
Closed
mergify[bot] wants to merge 2 commits into9.3from
Closed
[9.3](backport #48054) [Metricbeat] Add memory PSI metrics for cgroupv2#49057mergify[bot] wants to merge 2 commits into9.3from
mergify[bot] wants to merge 2 commits into9.3from
Conversation
## Proposed commit message
Add memory pressure PSI metrics to the system.process.cgroup.memory
metricset, complementing the existing CPU and IO pressure metrics.
New fields added under system.process.cgroup.memory.pressure:
- pressure.some.{10,60,300}.pct - Share of time with some tasks stalled
- pressure.some.total - Total some pressure time
- pressure.full.{10,60,300}.pct - Share of time with all tasks stalled
- pressure.full.total - Total full pressure time
Closes #47604
## How to test this PR locally
### 1. Build and Run Metricbeat
```bash
cd metricbeat
go build .
```
### 2. Create Test Configuration
```yaml
metricbeat.modules:
- module: system
period: 5s
metricsets:
- process
processes: ['.*']
process.cgroups.enabled: true
output.console:
pretty: true
```
### 3. Run Metricbeat
```bash
./metricbeat -e -c /tmp/metricbeat-psi-test.yml
```
### 4. Verify Memory Pressure Fields
Look for `system.process.cgroup.memory.pressure` in the output:
```json
"memory": {
"pressure": {
"some": {
"10": { "pct": 0 },
"60": { "pct": 0 },
"300": { "pct": 0 },
"total": 0
},
"full": {
"10": { "pct": 0 },
"60": { "pct": 0 },
"300": { "pct": 0 },
"total": 0
}
}
}
```
### 5. Compare Before/After (Optional)
[compare-psi-metrics.sh](https://github.com/user-attachments/files/24191696/compare-psi-metrics.sh)
Use the comparison script to compare output from main vs this PR:
```
compare-psi-metrics.sh
Usage: ./compare-psi-metrics.sh <main-output.ndjson> <pr-output.ndjson>
```
## Related issues
- Requires elastic/elastic-agent-system-metrics#274
- Closes #47604
(cherry picked from commit c3f35a9)
# Conflicts:
# NOTICE.txt
# go.mod
# go.sum
Contributor
Author
|
Cherry-pick of c3f35a9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
5 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Member
|
The diff is empty, the change is already in 9.3. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add memory pressure PSI metrics to the system.process.cgroup.memory
metricset, complementing the existing CPU and IO pressure metrics.
New fields added under system.process.cgroup.memory.pressure:
Closes #47604
Checklist
I have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.How to test this PR locally
1. Build and Run Metricbeat
2. Create Test Configuration
3. Run Metricbeat
4. Verify Memory Pressure Fields
Look for
system.process.cgroup.memory.pressurein the output:5. Compare Before/After (Optional)
compare-psi-metrics.sh
Use the comparison script to compare output from main vs this PR:
Related issues
This is an automatic backport of pull request #48054 done by [Mergify](https://mergify.com).