Skip to content

[8.19](backport #48026) filebeat: add kafka input tests for SASL PLAIN and SCRAM-SHA-256#48264

Merged
mauri870 merged 2 commits into8.19from
mergify/bp/8.19/pr-48026
Dec 30, 2025
Merged

[8.19](backport #48026) filebeat: add kafka input tests for SASL PLAIN and SCRAM-SHA-256#48264
mauri870 merged 2 commits into8.19from
mergify/bp/8.19/pr-48026

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 29, 2025 •
edited by mauri870
Loading

Proposed commit message

Our SASL integration tests for the Kafka input currently only cover SCRAM-SHA-512. Add tests for PLAIN and SCRAM-SHA-256 as well.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

(cd filebeat && mage docker:composeBuild && mage docker:composeUp)
go test -tags integration -v -run ^TestSASLAuthentication$ ./filebeat/input/kafka -v -count=1
./script/stresstest.sh --tags integration ./filebeat/input/kafka ^TestSASLAuthentication$ -p 1
(cd filebeat && mage docker:composeDown)
This is an automatic backport of pull request #48026 done by [Mergify](https://mergify.com).

@mauri870 @mergify
filebeat: add kafka input tests for SASL PLAIN and SCRAM-SHA-256 (#48026
071d131 
)

* filebeat: add testcase for SASL PLAIN and SCRAM-SHA-256 in kafka input

* fix linter errors

(cherry picked from commit 36d04b5)

# Conflicts:
#	filebeat/input/kafka/kafka_integration_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 29, 2025
@mergify mergify bot requested a review from a team as a code owner December 29, 2025 13:56
@mergify mergify bot requested review from andrzej-stencel and khushijain21 and removed request for a team December 29, 2025 13:56
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 29, 2025

Cherry-pick of 36d04b5 has failed:

On branch mergify/bp/8.19/pr-48026
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 36d04b525.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   testing/environments/docker/kafka/run.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   filebeat/input/kafka/kafka_integration_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2025
@mergify mergify bot mentioned this pull request Dec 29, 2025
Merged
6 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 29, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 29, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Copy Markdown
Member

mauri870 commented Dec 29, 2025

/test

@mauri870 mauri870 enabled auto-merge (squash) December 30, 2025 11:12
@mauri870 mauri870 merged commit 1c53f3d into 8.19 Dec 30, 2025
192 checks passed
@mauri870 mauri870 deleted the mergify/bp/8.19/pr-48026 branch December 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauri870 mauri870 mauri870 approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mauri870 mauri870

Labels

backport cleanup conflicts There is a conflict in the backported pull request skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @mauri870