Move winlogbeat to new publisher pipeline#4690
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jul 19, 2017
Merged
Conversation
andrewkroh
approved these changes
Jul 18, 2017
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. Thanks for refactoring the tests.
winlogbeat/beater/metrics.go
Outdated
Member
There was a problem hiding this comment.
I don't think this one is used anymore.
winlogbeat/eventlog/eventlog.go
Outdated
andrewkroh
reviewed
Jul 18, 2017
Member
There was a problem hiding this comment.
Is this missing a space after the period? nosetest output / log output
added 2 commits
July 19, 2017 01:38
- Move winlogbeat to publisher pipeline - move fields + tags processing to pipeline client - introduce local `processors` setting for each configured event log. - minor cleanups in tests
731ed74 to
701eda7
Compare
Author
|
@andrewkroh I rebased and squashed commits to most recent master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(beat.Client).Close()from being called multiple timesprocessorssetting for each configured event log.