Skip to content

[9.0](backport #45242) otel: add otel-specific fields to ingested docs#46498

Closed
mergify[bot] wants to merge 1 commit into9.0from
mergify/bp/9.0/pr-45242
Closed

[9.0](backport #45242) otel: add otel-specific fields to ingested docs#46498
mergify[bot] wants to merge 1 commit into9.0from
mergify/bp/9.0/pr-45242

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 10, 2025

Proposed commit message

This PR adds the otelcol.component.id and otelcol.component.kind to ingested beats receivers documents. These fields are exclusive to docs ingested by beats receivers and thus not present for standalone beats. In order to avoid conflicts with logs that already have these fields they are nested inside the beats event agent property.

See https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/component-universal-telemetry.md#receivers

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@mauri870 @mergify
otel: add otel-specific fields to ingested docs (#45242)
0c0ec95 
* otel: add otelcol.component.id field to ingested docs

* adjust otelcol field name

* rename otelcol.component.id in beats event to otel.component.name

* add otel.component.type

* update metricbeatreceiver unit tests

* add integration test coverage

* update receiver name in test pipeline

* use filestream as receiver name

* revert to otelcol.component.id and otelcol.component.kind

* fix tests

* ignore fields

* ignore otel fields in gcppubsub test

* move assertion on otel fields to the up

* fix linter issues

* handle existing otelcol.component.id

* prevent otelcol fields from being replaced if they exist

* put otelcol fields nested inside agent property

* fix E2E tests

* use EventuallyWithTf

(cherry picked from commit fafbdcb)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_test.go
#	x-pack/filebeat/input/gcppubsub/otel_test.go
#	x-pack/filebeat/tests/integration/otel_test.go
#	x-pack/libbeat/outputs/otelconsumer/otelconsumer.go
#	x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go
#	x-pack/metricbeat/tests/integration/otel_test.go
@mergify mergify bot added the backport label Sep 10, 2025
@mergify mergify bot requested a review from a team as a code owner September 10, 2025 11:05
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Sep 10, 2025
@mergify mergify bot requested a review from a team as a code owner September 10, 2025 11:05
@mergify mergify bot requested review from khushijain21 and removed request for a team September 10, 2025 11:05
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Sep 10, 2025

Cherry-pick of fafbdcb has failed:

On branch mergify/bp/9.0/pr-45242
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit fafbdcbd8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   libbeat/beat/info.go
	modified:   libbeat/otelbeat/oteltest/oteltest.go
	modified:   x-pack/filebeat/fbreceiver/factory.go
	modified:   x-pack/libbeat/cmd/instance/beat.go
	modified:   x-pack/metricbeat/mbreceiver/factory.go
	modified:   x-pack/metricbeat/mbreceiver/receiver_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   x-pack/filebeat/fbreceiver/receiver_test.go
	deleted by us:   x-pack/filebeat/input/gcppubsub/otel_test.go
	both modified:   x-pack/filebeat/tests/integration/otel_test.go
	both modified:   x-pack/libbeat/outputs/otelconsumer/otelconsumer.go
	both modified:   x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go
	deleted by us:   x-pack/metricbeat/tests/integration/otel_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from andrzej-stencel September 10, 2025 11:05
@mergify mergify bot mentioned this pull request Sep 10, 2025
Merged
6 tasks
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2025
@github-actions github-actions bot added cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Service Integrations Security Service Integrations Team labels Sep 10, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 10, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 10, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2025
@mauri870
Copy link
Copy Markdown
Member

mauri870 commented Sep 10, 2025

Closing since we're not backporting otel-related features to 9.0.

@mauri870 mauri870 closed this Sep 10, 2025
@mergify mergify bot deleted the mergify/bp/9.0/pr-45242 branch September 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mauri870 mauri870

Labels

backport cleanup conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Service Integrations Security Service Integrations Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @mauri870