[9.0](backport #46331) Fix Filebeat's race condition on shutdown#46396
Merged
[9.0](backport #46331) Fix Filebeat's race condition on shutdown#46396
Conversation
When Filebeat fails to start because of a unknown input, it can get into a deadlock state and never exit. This commit attempts to fix it. (cherry picked from commit 3ee3201)
6 tasks
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
pierrehilbert
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note for reviewers
The detailed description of the issue this PR solves can be found at #45034 (comment)
Proposed commit message
When Filebeat fails to start because of a unknown input, it can get into a deadlock state and never exit. This commit attempts to fix it.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
That's a non-deterministic problem, so testing is about running Filebeat over and over again and ensuring it never hangs during shutdown.
You can file the reproducing steps listed in the linked issue below, to run Filebeat over and over again, use the following script:
Assuming the script is named
rununtilfailand is~/bin/rununtilfail, you can run:Let it run for a few minutes, if Filebeat never hangs, then it's very likely the issue has been solved.
On my tests, it usually took less than 100 runs for Filebeat to hang, in more extreme cases it would take a couple thousand tries for Filebeat to hang.
Related issues
## Use cases## Screenshots## LogsThis is an automatic backport of pull request #46331 done by Mergify.