[8.19](backport #44909) [Filebeat] Do not run o365audit input and o365 module in FIPS builds#45040
Merged
ycombinator merged 1 commit into8.19from Jun 26, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
…lds (#44909) * Return error in FIPS mode if input wants to opt-out of FIPS distributions * Add ability for Filebeat plugins (inputs) to specify that they should be excluded from FIPS builds * Remove ExcludeForFIPS implementation * Make o365 input use FIPSAwareInput interface * Remove debugging statement * Adding godoc comments for implementations of the IsFIPSCapable() method * Add doc about module availability * Reimplementation * Remove duplicate imports (cherry picked from commit e0e464a)
30560a8 to
abe6fd0
Compare
ycombinator
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR ensures that the Filebeat
o365auditinput will not start in FIPS-capable distributions of Filebeat, as the input indirectly depends on code that is not FIPS-compliant. Specifically, theo365auditinput depends on thegithub.com/Azure/azure-sdk-for-go/sdk/azidentitypackage. This package, in turn, depends on thegolang.org/x/crypto/pkcs12package, which is not FIPS-compliant. Further, the SDK doesn't plan to offer a way to disable the use of this package at compile time (see Azure/azure-sdk-for-go#24336).In addition to the
o365auditinput, theo365module will also not start in FIPS-capable distributions of Filebeat, as this module uses theo365auditinput.Attempting to run a FIPS-capable distribution of Filebeat with either the
o365auditinput or theo365module configured will result in Filebeat not starting up and an error in the Filebeat logs like so:The
o365auditinput declares itself as not being FIPS-capable by setting theExcludeFromFIPSfield on thev2.Pluginstruct totrue(see also: #45036).Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
FIPS-capable artifacts of Filebeat will not start the
o365module or theo365auditinput.